-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify application #30
Comments
@NiklasBuchfink can you look at this? 😁 |
@felixhaeberle Can you provide me your settings for the Redirect URIs of the Spotify Dashboard? |
Link to the commit: commit-link ✅ Access Token in Frontend ToDo:
|
Good progress 👍 You can paste the commit hash it will automatically create a link from the hash text either in minified / maximized version has version. |
Same request with token from developer console of Spotify works, so the scope seems to be the problem. |
I thought the scope needs to be set in the spotify ui |
please check the PKCEClient code and check what's happening there with the scope when the request is coming back and how it gets persistent in the database via setToken and retrieved via getToken — please post investigation result here for further debugging help |
aaand don't know why we are putting that much effort in this although we don't have a working spotify oauth for everyone 😂 shouldn't we asked them first or how is the approval process there? |
The public application gets reviewed, that's why we have to do it now. Btw update, just the access token called back is wrong, the rest works fine. Also the full revalidation flow is needed, because the expire time is 3600 sec / 1h. |
@NiklasBuchfink Hey, just checkin it – why is this assigned to me? |
@felixhaeberle pls check if the src/client/api/connector.ts is fine regarding the typescript interfaces. The code_verifier must be passed through the authorizationRequest function and is optional for the authorize function. Otherwise this issue can be closed 🎉🎵 |
well done 🎉 what is left with the interfaces? are there errors? have you tested everything, also with the other APIs? |
No Errors, GitHub works as well. Just jf there is a prettier way to implement this with making the Prop optional and pass it through. |
Write access application to Spotify
The text was updated successfully, but these errors were encountered: