diff --git a/basic-frame/src/dynamic_frame.rs b/basic-frame/src/dynamic_frame.rs index d6a46d959..7e5847930 100644 --- a/basic-frame/src/dynamic_frame.rs +++ b/basic-frame/src/dynamic_frame.rs @@ -116,7 +116,8 @@ impl DynamicFrame { convert_to_dynamic2!(FMT, new_basic_frame_copy!(frame)) } - // TODO: actually implement the From trait + // TODO: actually implement the From trait. However, this is more difficult + // than it may initially sound because of trait generic stuff. pub fn from(frame: FRAME) -> Self where FRAME: ImageStride + Into>, @@ -161,6 +162,10 @@ impl DynamicFrame { /// Return the image as a `BasicFrame` converting the data to the requested /// pixel format as necessary. /// + /// Note that although this consumes [Self], it does not make sense to + /// implement a variant which takes only a reference because the data must + /// be copied in that case anyway. + /// /// To avoid converting the data, use [Self::as_basic]. pub fn into_pixel_format(self) -> Result, convert_image::Error> where