Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hostname for klipper #27

Closed
matthawley opened this issue Feb 3, 2024 · 7 comments
Closed

Support hostname for klipper #27

matthawley opened this issue Feb 3, 2024 · 7 comments
Labels
next-release Issue is fixed/implemented but not released yet

Comments

@matthawley
Copy link
Contributor

Could you support adding your klipper instance by hostname and not just IP? I've went ahead and made my IP static (I think) but it would be much easier to reference it by hostname (but also still support IP).

@suchmememanyskill
Copy link
Owner

In my experience with networking hostname is super inconsistent. I'd rather not.

Can't you uh, set up your router's default dns to include an entry for your machine?

@matthawley
Copy link
Contributor Author

I'd argue otherwise - my IP is inconsistent if using DHCP (the default for wireless routers) but my hostname of my raspberry pi (or any other computer) is static. My router does provide internal DNS for hostnames, but this install ONLY allowed me to enter my instance by IP (unless I was completely blind and couldn't find a way to switch away from numeric input).

@matthawley
Copy link
Contributor Author

Looking through the code, it seems you're just making an http request through an http client, which should work with a hostname. It might be as simple as not setting the keyboard mode (or making numeric entry default)?

lv_keyboard_set_mode(keyboard, LV_KEYBOARD_MODE_NUMBER);

@suchmememanyskill
Copy link
Owner

suchmememanyskill commented Feb 4, 2024

@matthawley could you fork it and try it? (Github actions should automatically produce a new binary for you, you can flash the merged firmware bin it generates. I've explained how to flash it in the keyboard characters issue)

@matthawley
Copy link
Contributor Author

matthawley commented Feb 4, 2024

@suchmememanyskill will do! Is this the correct documentation for the keyboard? If so, we could probably create a custom keyboard to only include a-z, 0-9 and . characters

https://docs.lvgl.io/master/widgets/keyboard.html#overview

@suchmememanyskill
Copy link
Owner

@suchmememanyskill will do! Is this the correct documentation for the keyboard? If so, we could probably create a custom keyboard to only include a-z, 0-9 and . characters

https://docs.lvgl.io/master/widgets/keyboard.html#overview

I'm using lvgl v8, but looks like it. i have a fork set up for keyboard changes if needed

@matthawley
Copy link
Contributor Author

Added updated keyboard in #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Issue is fixed/implemented but not released yet
Projects
None yet
Development

No branches or pull requests

2 participants