-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hostname for klipper #27
Comments
In my experience with networking hostname is super inconsistent. I'd rather not. Can't you uh, set up your router's default dns to include an entry for your machine? |
I'd argue otherwise - my IP is inconsistent if using DHCP (the default for wireless routers) but my hostname of my raspberry pi (or any other computer) is static. My router does provide internal DNS for hostnames, but this install ONLY allowed me to enter my instance by IP (unless I was completely blind and couldn't find a way to switch away from numeric input). |
Looking through the code, it seems you're just making an http request through an http client, which should work with a hostname. It might be as simple as not setting the keyboard mode (or making numeric entry default)? CYD-Klipper/CYD-Klipper/src/ui/ip_setup.cpp Line 111 in 2a2fff2
|
@matthawley could you fork it and try it? (Github actions should automatically produce a new binary for you, you can flash the merged firmware bin it generates. I've explained how to flash it in the keyboard characters issue) |
@suchmememanyskill will do! Is this the correct documentation for the keyboard? If so, we could probably create a custom keyboard to only include |
I'm using lvgl v8, but looks like it. i have a fork set up for keyboard changes if needed |
Added updated keyboard in #28 |
Could you support adding your klipper instance by hostname and not just IP? I've went ahead and made my IP static (I think) but it would be much easier to reference it by hostname (but also still support IP).
The text was updated successfully, but these errors were encountered: