Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag to turn off caption display for now #1497

Closed
andrewjbtw opened this issue May 17, 2023 · 0 comments · Fixed by #1499
Closed

Add feature flag to turn off caption display for now #1497

andrewjbtw opened this issue May 17, 2023 · 0 comments · Fixed by #1499
Assignees
@edsu

Comments

@andrewjbtw
Copy link

andrewjbtw commented May 17, 2023 •
edited
Loading

PR: #1469 to add display of VTT captions has been merged but caption display is not ready for production release.

This ticket is a follow-on to discussion in that PR to use a feature flag to prevent caption display from being turned on until more time is dedicated to captions.
@edsu edsu self-assigned this May 17, 2023
edsu added a commit that referenced this issue May 19, 2023
@edsu
Add feature flag for transcripts
9971846 
The `Settings.enabled_features.transcripts` flag was added to control
whether the viewer will display a track element containing the
transcript for a video.

The setting can be toggled by adding `?trascripts=true` to the URL for
the embed viewer. This will require you to look at the view directly
instead of embedded in PURL or SearchWorks.

Resolves #1497
@edsu edsu mentioned this issue May 19, 2023
Merged
edsu added a commit that referenced this issue May 19, 2023
@edsu
Add feature flag for transcripts
c3ab3af 
The `Settings.enabled_features.transcripts` flag was added to control
whether the viewer will display a track element containing the
transcript for a video.

The setting can be toggled by adding `?trascripts=true` to the URL for
the embed viewer. This will require you to look at the view directly
instead of embedded in PURL or SearchWorks.

Resolves #1497
edsu added a commit that referenced this issue May 19, 2023
@edsu
Add feature flag for transcripts
135ad9d 
The `Settings.enabled_features.transcripts` flag was added to control
whether the viewer will display a track element containing the
transcript for a video.

The setting can be forced on by adding `?trascripts=true` to the URL for
the embed viewer. This will require you to look at the view directly
instead of embedded in PURL or SearchWorks.

Resolves #1497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsu edsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature flag for transcripts sul-dlss/sul-embed
2 participants
@edsu @andrewjbtw