Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display uncorrected captions by default #2262

Open
andrewjbtw opened this issue Nov 22, 2024 · 4 comments · May be fixed by #2275
Open

Do not display uncorrected captions by default #2262

andrewjbtw opened this issue Nov 22, 2024 · 4 comments · May be fixed by #2275
Assignees
@dnoneill
Labels
implementation-question

Comments

@andrewjbtw
Copy link

We currently enable caption display by default when the viewer loads. If we can detect when captions are auto-generated and not corrected, we should not display those by default. The user can still enable them by choice.

We should be able to rely on Cocina to detect auto-generated and uncorrected captions. The values will be:

  • sdrGenerated: true
  • correctedForAccessibility: false

Additional information

This ticket will match up with a future ticket to label when captions are auto-generated and uncorrected so that users know what they are viewing.
@jmartin-sul
Copy link
Member

might be two parts: not sure exactly how sul-embed gets this info, or whether it has easy access to this info now. may need to work in other systems too to pass the info along.

@peetucket
Copy link
Member

It appears that we are already publishing the metadata we need from cocina to PURL. See for example this media integration test object: https://sul-purl-stage.stanford.edu/pz039vb9760.json

Image

@dnoneill
Copy link
Contributor

dnoneill commented Dec 4, 2024

Yes. Should be doable. Would suggest working off this branch https://github.com/sul-dlss/sul-embed/pull/2267/files as sdr_generated is added there.

@dnoneill
Copy link
Contributor

dnoneill commented Dec 5, 2024

How to do this is here: https://github.com/sul-dlss/sul-embed/compare/auto-generated-captions...2262-uncorrect-default?expand=1

@dnoneill dnoneill linked a pull request Dec 5, 2024 that will close this issue
Open
@dnoneill dnoneill self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnoneill dnoneill

Labels
implementation-question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't display auto-generated captions by default sul-dlss/sul-embed
4 participants
@peetucket @jmartin-sul @andrewjbtw @dnoneill