Skip to content
This repository has been archived by the owner on Aug 2, 2018. It is now read-only.

PlanChangePolicy changing subscription period instead of price #8

Open
shnela opened this issue Jun 13, 2017 · 2 comments
Open

PlanChangePolicy changing subscription period instead of price #8

shnela opened this issue Jun 13, 2017 · 2 comments

Comments

@shnela
Copy link

shnela commented Jun 13, 2017

Now we can charge user for changing plan when he wants to upgrade it, but when user choose cheaper option all we can do is allowing him doing it for free. It's unfair.
Here should be option for changing UserPlan.expire when changing plan.

@cdvv7788
Copy link

This feature should be assuming plans basic (10USD) and premium (20USD):
basic -> premium: Calculate the price difference, charge the user and change plan. The end expiration date should remain the same, the amount paid was only for the plan change.
premium -> basic: Calculate how much time the user should have with the remaining money in the cheaper plan and change plan and move expiration date into the future according to that.

@shnela If i understand you correctly, the second condition is not working. Am i right?

@cdvv7788 cdvv7788 assigned cdvv7788 and unassigned cdvv7788 Jun 14, 2017
@rdlabspl
Copy link

@cdvv7788 yes, there's problem with second option (assuming that we want to be fair with our clients).

I think that there should be two kinds of strategy. First, which calculates charge for changing plan, and second which will calculate new expiration date when user chose cheaper option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants