Add XCTAssertNoThrowAsync and XCTAssertThrowsErrorAsync
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jiyimeta, thanks for your interest in improving XCTest. Unfortunately we aren't accepting new APIs here on the swift-corelibs-xctest repository, because its primary purpose is to provide a compatible implementation of the APIs provided by the XCTest that ships with Xcode, for use when targeting platforms that Xcode doesn't support. I recommend that you keep these additional APIs in your own project/package, and file an Xcode enhancement request at http://bugreport.apple.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
XCTAssertNoThrowAsyncandXCTAssertThrowsErrorAsync, which are the async versions ofXCTAssertNoThrowandXCTAssertThrowsError.I adopted different names from sync ones in order to avoid confusion of overloads.
For example, if the sync and async versions have the same name
XCTAssertThrowsError,such a sync assertion in an async context will cause compile error with message
Expression is 'async' but is not marked with 'await', despite success before this change.Resolves #419.