Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Foundation file operations with NIOFileSystem #125

Open
adam-fowler opened this issue Jun 19, 2024 · 3 comments
Open

Replace Foundation file operations with NIOFileSystem #125

adam-fowler opened this issue Jun 19, 2024 · 3 comments

Comments

@adam-fowler
Copy link
Contributor

No description provided.

@cmcgee1024
Copy link
Member

What are the benefits to swiftly from switching to NIOFilesystem? One reason appears to be that the operations are asynchronous, which could work well with the async codebase here.

@adam-fowler
Copy link
Contributor Author

One reason appears to be that the operations are asynchronous, which could work well with the async codebase here.

That's pretty much it. It is currently the only fully async file system we have in Swift.

@cmcgee1024
Copy link
Member

cmcgee1024 commented Sep 12, 2024

It looks like NIOFilesystem uses FilePath from System(Package), which is nice in the sense that it preserves the OS native path structure instead of normalizing to a URL, or using a bare string without the path arithmetic operations. We could start with sweeping all of the URL paths, changing them into FilePaths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants