Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1264 - Tapestry 3.0 - Double-click to open node and hide media button until hovered #1267

Closed
wants to merge 7 commits into from
Closed

1264 - Tapestry 3.0 - Double-click to open node and hide media button until hovered #1267

wants to merge 7 commits into from

Conversation

legendword
Copy link
Contributor

@legendword legendword commented Oct 31, 2022 •
edited
Loading

Changes

  • Refactor hasPermission("edit") into canEdit computed property in TapestryNode to avoid multiple calls to hasPermission.
  • Only show media button when the node is hovered (except for users with edit permission on that node, who will still always still the media button).
  • Double click a node to open the lightbox (except for users with edit permission on that node, in which case they can edit the title in place by double clicking).

Screenshot

image

Issue Linkage

Closes #1264

PR Dependency

Depends on: #1227

@cypress
Copy link

cypress bot commented Oct 31, 2022 •
edited
Loading


Test summary

95 • 0 • 0 • 0 • Flakiness 1

Run details
Project tapestry-wp
Status Passed
Commit 88fe230
Started Dec 14, 2022 11:29 PM
Ended Dec 14, 2022 11:34 PM
Duration 04:18 💡
OS Linux Ubuntu - 22.04
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/lightbox/video.spec.js 1 Flakiness
1 Video > adding a kaltura video should also set a thumbnail

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@legendword legendword added the needs final review Has been tested and reviewed once and needs another code review to become ready for merge label Oct 31, 2022
@legendword legendword linked an issue Oct 31, 2022 that may be closed by this pull request
Double-click to open node and hide media button until hovered #1264
Open
@legendword legendword changed the title 1264 - Double-click to open node and hide media button until hovered 1264 - Tapestry 3.0 - Double-click to open node and hide media button until hovered Dec 12, 2022
@legendword legendword mentioned this pull request Dec 12, 2022
Closed
@wynnset wynnset closed this Jan 6, 2023
@wynnset wynnset deleted the 1264-hide-media-btn branch January 18, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wynnset wynnset

Labels
needs final review Has been tested and reviewed once and needs another code review to become ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-click to open node and hide media button until hovered
2 participants
@legendword @wynnset