2 flaky tests on run #3974 ↗︎

0

100

0

0

2

Details:

  node-authoring.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Node Authoring > should not be able to delete a non-leaf node		Output Screenshots Video

  lightbox/multicontent.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Multi-content > In-place > should be able to add/edit/delete multi-content child node in-place		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

The Kaltura fixes are working and the refactoring looks good. Just waiting to test if loading multiple Kaltura scripts from different Kaltura servers breaks anything (when calling kWidget.embed, the kWidget global variable can only be from the latest loaded kWidget script).

Indeed, after testing, two videos from different Kaltura servers will not be played properly, especially of they are in the same multi-content node. The Kaltura script that is loaded last will overwrite any existing kWidget global variable. Currently we are not planning to fix this, as most Tapestry sites using Kaltura are only using videos from one server. If a situation arises that require more than one Kaltura server to be used, this issue will need to be reconsidered.

After reviewing the PR description, there is one item that might have been fixed but is now still a problem:

• Fix issue where player would play in the background with pop-up on top if seeked past a pop-up time

Some notes after I did a bit of testing (for context, this is a Kaltura video with Kaltura player and a popup node at 10 seconds). Tried seeking from before 10s to after 10s multiple times. The popup does not trigger every time (see below).

Scenario 1: lastTime update happens after seeking, meaning the lastTime is already updated and it is not considered to have sought over the 10s threshold. The popup does not trigger.

Scenario 2: lastTime update happens before seeking, so the popup at 10s triggers. The pause command is sent to the Kaltura player, yet the video is not paused.

If playing video normally without seeking, the popup always shows up normally and the video is paused normally: