Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router: deprecate vshard.router.bucket_discovery #503

Open
Serpentian opened this issue Dec 5, 2024 · 1 comment
Open

router: deprecate vshard.router.bucket_discovery #503

Serpentian opened this issue Dec 5, 2024 · 1 comment
Assignees
@Astronomax
Labels
router

Comments

@Serpentian
Copy link
Contributor

Serpentian commented Dec 5, 2024 •
edited
Loading

The function does absolutely the same as vshard.router.route. Probably, some time ago there were difference in these functions but now there're the same. We probably can safely deprecate vshard.router.bucket_discovery, as it's marked as "Internal API" in docs and subsequently can be changed or removed at any time. @Gerold103
@Serpentian Serpentian mentioned this issue Dec 5, 2024
Open
@Gerold103
Copy link
Collaborator

I don't mind deleting it. If it is internal and isn't used by vshard itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Astronomax Astronomax

Labels
router
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gerold103 @Astronomax @Serpentian