Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altitude not set for address #213

Open
epicblood opened this issue Aug 7, 2016 · 5 comments
Open

Altitude not set for address #213

epicblood opened this issue Aug 7, 2016 · 5 comments

Comments

@epicblood
Copy link
Contributor

Expected Behavior

Altitude is set for all locations

Actual Behavior

When an address is specified for start location ("Central Park, New York, NY"), altitude is set to 0,
if the coords of this address are used ("40.7711329,-73.97418739999999") altitude is looked up and set.

Steps to Reproduce

start bot with non-coord location

Other Information

OS: Debian Testing
Git Commit: 7036153

@andythorne
Copy link
Collaborator

I think this could be extended to altitude is ONLY set when using geolocation on in it (i.e. It's not correctly set on each step either).

The only way I've found how to do this is call Google's elevation api every time we set the location.

@tegob
Copy link
Contributor

tegob commented Aug 8, 2016

The only way I've found how to do this is call Google's elevation api every time we set the location.

Stating the obvious here but don’t forget to add a random value that is generated once per bot session to the altitude you’re getting this way. I’d suggest something like random.uniform(0.9, 1.7) meters. People don’t put their phones on the ground while playing Pokémon GO.

@xasdf
Copy link

xasdf commented Aug 10, 2016

I think pgoapi just sets altitude to 8 anyway regardless of what you set it to (see rpc_api.py).
That being said it is a bug. They should only do this hack if altitude is set to 0 in request.

@andythorne maybe get target fort altitude and then interpolate as bot moves?

@niicojs
Copy link
Contributor

niicojs commented Aug 10, 2016

maybe @wchill can commit to fix to the api and set 8 only if altitude is not set

@meyer9
Copy link
Contributor

meyer9 commented Aug 12, 2016

I REALLY doubt Niantic checks/will ever check exact altitude for a location. This is a pretty low priority issue IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants