-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: v0.31.0 failing due to docker type removed in docker/docker dependency #2583
Comments
Hm. I think those types were marked as deprecated since v26.0.0, which added temporary aliases to point to the new location; https://github.com/moby/moby/blob/v26.0.0/api/types/types_deprecated.go#L7-L35 (and those are removed with the v27.xx release @mdelapenya do you know if there's a linter in this repository that would check for those deprecations? |
Ah, looks like this repo depends on v25.0.0, so yes, updating to two major versions ahead is somewhat expected to break things; Line 10 in 5d68a52
I guess we can update it to v26.1, and adjust the code |
@thaJeztah thanks for checking. Indeed, I'm going to bump docker version to v26.1 then. |
I have a branch; pushing a PR now 😄 |
When will a new version with this fix be released? |
I resolved this issue by updating to v0.34.0:
|
Testcontainers version
0.31.0
Using the latest Testcontainers version?
Yes
Host OS
MacOS
Host arch
ARM64
Go version
1.22.3
Docker version
Client: Cloud integration: v1.0.35+desktop.13 Version: 26.1.1 API version: 1.45 Go version: go1.21.9 Git commit: 4cf5afa Built: Tue Apr 30 11:44:56 2024 OS/Arch: darwin/arm64 Context: desktop-linux Server: Docker Desktop 4.30.0 (149282) Engine: Version: 26.1.1 API version: 1.45 (minimum version 1.24) Go version: go1.21.9 Git commit: ac2de55 Built: Tue Apr 30 11:48:04 2024 OS/Arch: linux/arm64 Experimental: false containerd: Version: 1.6.31 GitCommit: e377cd56a71523140ca6ae87e30244719194a521 runc: Version: 1.1.12 GitCommit: v1.1.12-0-g51d5e94 docker-init: Version: 0.19.0 GitCommit: de40ad0
Docker info
What happened?
Updated testcontainers package to latest:
Saw several dependencies update, including:
go: upgraded github.com/docker/docker v26.1.0+incompatible => v27.0.0+incompatible
Ran tests and received output in next section
Relevant log output
Additional information
Docker confirmed in this issue that v27.0.0 is a release candidate version accidentally tagged as a full version and that they should be releasing the actual full version (v27.0.1) sometime next week. With the errors given and the fact that the version is still a candidate for release, wanted to give testcontainers a heads up in case these changes are permanent.
Also, thank you for your amazing package!! It has been a blessing on our team and we truly appreciate all the effort the people behind this put in 🙇🏾
The text was updated successfully, but these errors were encountered: