Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename EnpointSettingsModifier to EndpointSettingsModifier #2941

Merged

Conversation

NathanBaulch
Copy link
Contributor

Rename EnpointSettingsModifier to EndpointSettingsModifier, as discussed in #2940.

@NathanBaulch NathanBaulch requested a review from a team as a code owner January 14, 2025 00:23
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 483dbf2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6785ae7cb04c360008d6c3d6
😎 Deploy Preview https://deploy-preview-2941--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Jan 14, 2025
@mdelapenya mdelapenya added the breaking change Causing compatibility issues. label Jan 14, 2025
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya changed the title fix!: typo in EnpointSettingsModifier chore!: rename EnpointSettingsModifier to EndpointSettingsModifier Jan 14, 2025
@mdelapenya
Copy link
Member

@NathanBaulch I've renamed the PR so that it's even clearer when reading the release notes.

@mdelapenya mdelapenya merged commit 8b5211f into testcontainers:main Jan 14, 2025
125 checks passed
@NathanBaulch NathanBaulch deleted the enpointsettingsmodifier branch January 14, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Causing compatibility issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants