MSVC Toolchain Support

[theduke]

Provide a clean error message when building -sys on Windows with msvc.

(Just a reminder for myself)

[l0calh05t]

Would it be feasible to use https://github.com/c-smile/quickjspp instead?

[l0calh05t]

I tried it and while it builds on both MSVC and Linux now (haven't tried MinGW-Windows or MacOS), the tests crash instantly on Windows (ctx->rt is null in eval even though runtime wasn't null during creation). Linux tests still pass, though.

[l0calh05t]

Ok - I just noticed you don't run bindgen when using the embedded QuickJS. When building with different defines this is of course necessary. However, it isn't as trivial as just running bindgen, because JsValue is no longer a union etc.

[payallmoney]

Whether there has been any progress on this matter ? I need msvc ...

[l0calh05t]

@payallmoney Haven't gotten around to doing anything further. You can check the current state on https://github.com/l0calh05t/quickjs-rs (but the MSVC version will not build, as it requires a different FFI! it would probably be best to create functions equivalent to the macros used in the header and then use those throughout the FFI)

[payallmoney]

@payallmoney Haven't gotten around to doing anything further. You can check the current state on https://github.com/l0calh05t/quickjs-rs (but the MSVC version will not build, as it requires a different FFI! it would probably be best to create functions equivalent to the macros used in the header and then use those throughout the FFI)

Ok , i will try , thanks for your reply .

[theduke]

There is a patch that adds msvc support here: bellard/quickjs#49

It's rather large, but I'm considering including this here.