-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.4.0 is breaking dependent CJS packages #10
Comments
My temporary workaround is to force a version resolution in my SvelteKit app's {
"resolutions": {
"es-cookie": "1.3.2"
}
} |
Same issue. In my case its being used in auth0/auth0-spa-js library as well. |
I released the native ES module update as v1.4 instead of v2.0 since there is no change to the documented public API, and when using a module bundler such as Rollup or Webpack the library should continue working seamlessly. If your project can't support the ESM version for some reason, can you pin es-cookie to v1.3.2 (e.g. via package-lock.json or npm overrides)? If I were to publish v1.4.1 as a CommonJS module instead of ESM, that could also be a breaking change for people already depending on the new ESM version... |
worked for me, thanks. but isn't this a breaking change? |
I have a SvelteKit app that is dependent on @auth0/auth0-spa-js. That library is currently CJS and is dependent on es-cookie@^1.3.2.
My app is crashing with the following message because [email protected] turned to an ESM package in a non-breaking version minor upgrade (which @auth0/auth0-spa-js assumed was fine):
Is it possible to revert the new ESM changes of v1.4.0 as v1.4.1 and release them as a new v2.0.0 instead (to respect semver)?
The text was updated successfully, but these errors were encountered: