Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Completed Tournaments crash #247

Open
florence-wolfe opened this issue Jun 12, 2024 · 0 comments
Open

[BUG] - Completed Tournaments crash #247

florence-wolfe opened this issue Jun 12, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@florence-wolfe
Copy link
Collaborator

Currently, completed tournament pages will crash because they are looking for a Live Run to display within the Twitch embedded player.

The fix should be as simple as:

  • in tournament.tsx check if we have a currentViewer before calling liveRunFromUser on L161
  • if the event has ended or there's no currentViewer hide the live run section altogether
    • Open Question: if there are no runners for an active tournament should the twitch embed section be hidden?
@florence-wolfe florence-wolfe added bug Something isn't working good first issue Good for newcomers labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant