Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues found by Markus Kirschmer #1314

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix some issues found by Markus Kirschmer #1314

merged 1 commit into from
Dec 5, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Dec 5, 2023

No description provided.

@thofma
Copy link
Owner Author

thofma commented Dec 5, 2023

@mkirschm for consistency I did copy = true by default.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1314 (37cd5a7) into master (776e633) will increase coverage by 0.05%.
The diff coverage is 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   74.53%   74.59%   +0.05%     
==========================================
  Files         346      346              
  Lines      111552   111827     +275     
==========================================
+ Hits        83150    83412     +262     
- Misses      28402    28415      +13     
Files Coverage Δ
src/NumFieldOrd/NfOrd/Ideal/Ideal.jl 82.71% <100.00%> (+1.52%) ⬆️
src/NumFieldOrd/NfOrd/FracIdeal.jl 88.42% <87.50%> (+0.03%) ⬆️

... and 57 files with indirect coverage changes

@thofma thofma merged commit 811bb87 into master Dec 5, 2023
19 checks passed
@thofma thofma deleted the th/markus branch December 5, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant