Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor space typo in the AbsAlgAssMor output after decomposition of group_algebra #1715

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Jan 1, 2025

It seems there is a minor space typo as there is no space after order 5 in the output below:

julia> C = abelian_group(5);

julia> GA = group_algebra(GF(3), C);

julia> d = decompose(GA);

julia> d[1][2]
Map
  from structure constant algebra of dimension 1 over GF(3)
  to group algebra of group of order 5over GF(3)

I think the first output line is printed correctly from:

print(io, "Structure constant algebra of dimension ", dim(A), " over ")
print(terse(io), Lowercase(), base_ring(A))

It seems the typo is due to this line, no space before over, it should be " over " as in the earlier clause

print(io, "over ")

Please help review this PR, thank you!

Copy link
Contributor

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately creates a double-space in the case of an infinite group. To resolve this, I think the cleanest solution would be to revert your change here and instead add a trailing space to the print in line 181

@Fe-r-oz Fe-r-oz marked this pull request as draft January 2, 2025 14:18
@Fe-r-oz Fe-r-oz marked this pull request as ready for review January 2, 2025 14:43
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Jan 2, 2025

Thank you for your suggestion! Hopefully this works okay.

@thofma thofma enabled auto-merge (squash) January 2, 2025 21:46
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.06%. Comparing base (3f9f55b) to head (9be2f47).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1715   +/-   ##
=======================================
  Coverage   76.06%   76.06%           
=======================================
  Files         361      361           
  Lines      114378   114377    -1     
=======================================
  Hits        86999    86999           
+ Misses      27379    27378    -1     
Files with missing lines Coverage Δ
src/AlgAss/AlgGrp.jl 75.12% <100.00%> (ø)

... and 29 files with indirect coverage changes

@thofma thofma merged commit cc62e1c into thofma:master Jan 3, 2025
17 checks passed
@Fe-r-oz Fe-r-oz deleted the fa/fix-printing-typo branch January 3, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants