Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aliasing bug in mul! of LocalFieldElem #1718

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: aliasing bug in mul! of LocalFieldElem #1718

merged 1 commit into from
Jan 8, 2025

Conversation

thofma
Copy link
Owner

@thofma thofma commented Jan 8, 2025

No description provided.

@thofma thofma requested a review from fieker January 8, 2025 08:47
Copy link
Collaborator

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how long did it take to find this? Well done!

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.98%. Comparing base (cc62e1c) to head (dfb2434).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1718       +/-   ##
===========================================
+ Coverage    6.49%   75.98%   +69.49%     
===========================================
  Files         361      361               
  Lines      114238   114377      +139     
===========================================
+ Hits         7419    86910    +79491     
+ Misses     106819    27467    -79352     
Files with missing lines Coverage Δ
src/LocalField/Elem.jl 82.37% <100.00%> (+82.37%) ⬆️

... and 321 files with indirect coverage changes

@thofma thofma enabled auto-merge (squash) January 8, 2025 10:39
@thofma thofma merged commit 039acfa into master Jan 8, 2025
18 checks passed
@thofma thofma deleted the th/alias branch January 8, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants