fix: add missing hash methods #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Jan 8, 2025
There was a problem hiding this comment.
OrdLocElem from the list in oscar-system/Oscar.jl#2222 is still missing
lgoettgens
reviewed
Jan 8, 2025
|
Thanks. Should all be addressed now. |
lgoettgens
approved these changes
Jan 8, 2025
fieker
reviewed
Jan 8, 2025
| @@ -276,6 +276,10 @@ function ==(A::GenOrdFracIdl, B::GenOrdFracIdl) | |||
| return isone(denominator(C, copy = false)) && isone(norm(C)) | |||
| end | |||
|
|
|||
| function Base.hash(A::GenOrdFracIdl, h::UInt) | |||
| return hash(order(A), hash(basis_matrix(A), h)) | |||
There was a problem hiding this comment.
is the matrix guaranteed to be in HNF? With a unque HNF?
There was a problem hiding this comment.
We already use it for hashing of GenOrdIdl so I had hoped that it is fine.
Co-authored-by: Lars Göttgens <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1719 +/- ##
===========================================
+ Coverage 6.49% 76.00% +69.51%
===========================================
Files 361 361
Lines 114238 114387 +149
===========================================
+ Hits 7419 86941 +79522
+ Misses 106819 27446 -79373
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.