Mutable request in axum middleware with async logic #2893

joebnb · 2024-08-28T13:15:38Z

joebnb
Aug 28, 2024

Summary

i have question about axum handle async logic in middleware, and already searched there no similar question before. the most similiar is #2213,but it's didn't resolve my problem.

i have a auth middleware, it will get user id and session id from request cookie, and do a match in redis asynchronous ,if match the user, the user information will add into request extension and pass to request handler, in before i user memory synchronous method to do this is ok,now i have to change it into asynchronous,but have some problem please give some advice to help me to make it work.

this code is reference form https://docs.rs/axum/latest/axum/middleware/index.html#towerservice-and-pinboxdyn-future

impl<S> Layer<S> for AuthLayer {
    type Service = AuthMiddleware<S>;
    fn layer(&self, inner: S) -> Self::Service {
        AuthMiddleware {
            inner,
            whitelist: self.whitelist.clone(),
            state: self.state.clone(),
        }
    }
}

#[derive(Clone)]
pub struct AuthMiddleware<S> {
    inner: S,
    pub whitelist: Vec<String>,
    pub state: Arc<AppState>,
}

impl<S> Service<Request> for AuthMiddleware<S>
where
    S: Service<Request, Response = Response<Body>> + Send + 'static,
    S::Future: Send + 'static,
{
    type Response = S::Response;
    type Error = S::Error;
    type Future =
        Pin<Box<dyn Future<Output = Result<Self::Response, Self::Error>> + Send + 'static>>;

    fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
        self.inner.poll_ready(cx)
    }

    fn call(&mut self, mut request: Request) -> Self::Future {
        let path = request.uri().path();

        let cookies = CookieJar::from_headers(request.headers());
        let session_id = cookies
            .get("token")
            .and_then(|token| Some(token.value().to_string()));
        let user_id = cookies
            .get("user_id")
            .and_then(|user| Some(user.value().to_string())); 

       if let (Some(user_id), Some(session_id)) = (user_id, session_id) {
            let state = self.state.clone();
            let this_self = Arc::new(Mutex::new(self)).clone();    //  it's need pass self into a async function ,this arc mutex seem not work as expect, inner call still not have enough lifetime
 
            return Box::pin(async move {
                let session_user = validation_token(state, &user_id, &session_id).await;

                if let Some(user) = session_user {
                    request.extensions_mut().insert(user); // i need instert user in to request  extensions
                    let future = this_self.lock().unwrap().inner.call(request);   // here is need self.inner.call
                    let response = future.await?;
                    return Ok(response);
                }
                let response = guard_response();
                Ok(response)
            });
      
        let response = guard_response();
        return Box::pin(async move { Ok(response) });
    }
}

error: lifetime may not live long enough
  --> src/app/middleware/auth_middleware.rs:81:20
   |
54 |       fn call(&mut self, mut request: Request) -> Self::Future {
   |               - let's call the lifetime of this reference `'1`
...
81 |               return Box::pin(async move {
   |  ____________________^
82 | |                 let session_user = validation_token(state, &user_id, &session_id).await;
83 | |
84 | |                 if let Some(user) = session_user {
...  |
92 | |                 Ok(response)
93 | |             });
   | |______________^ returning this value requires that `'1` must outlive `'static`

i found use this would be resolve problem,but still want to know how to resolve on upper code

axum version

0.7.5

mladedav · 2024-08-28T17:12:40Z

mladedav
Aug 28, 2024
Collaborator

This is not strictly an Axum problem, rather general async problem. l

What you're trying to do is create a boxed future which can possibly live indefinitely and since you're returning it, it will surely outlive the function. However, you're trying to smuggle the mutable reference to self in there and rustc will not let you. You can't make the reference outlive the function.

You can add a bound and just clone the inner service and pass that inside the async block. Be sure to plcall poll_ready on the cloned service, not the original though.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mutable request in axum middleware with async logic #2893

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment

{{title}}

Select a reply

Mutable request in axum middleware with async logic #2893

joebnb Aug 28, 2024

Summary

axum version

Replies: 1 comment

mladedav Aug 28, 2024 Collaborator

joebnb
Aug 28, 2024

mladedav
Aug 28, 2024
Collaborator