Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyArr Async Support #93

Closed
wants to merge 3 commits into from
Closed

PyArr Async Support #93

wants to merge 3 commits into from

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 14, 2022 •
edited
Loading

This PR will...

We should also look into procedurally generating docstrings based on type hints.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 14, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.32%.

Quality metrics Before After Change
Complexity 0.89 ⭐ 1.23 ⭐ 0.34 👎
Method Length 26.61 ⭐ 23.17 ⭐ -3.44 👍
Working memory 6.29 🙂 6.17 ⭐ -0.12 👍
Quality 87.10% ⭐ 86.78% ⭐ -0.32% 👎
Other metrics Before After Change
Lines 2143 2129 -14
Changed files Quality Before Quality After Quality Change
pyarr/base.py 92.26% ⭐ 93.77% ⭐ 1.51% 👍
pyarr/radarr.py 91.20% ⭐ 92.13% ⭐ 0.93% 👍
pyarr/readarr.py 75.75% ⭐ 73.21% 🙂 -2.54% 👎
pyarr/request_handler.py 82.66% ⭐ 82.88% ⭐ 0.22% 👍
pyarr/sonarr.py 90.17% ⭐ 91.06% ⭐ 0.89% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyarr/readarr.py ReadarrAPI._book_json 7 ⭐ 148 😞 15 😞 48.36% 😞 Try splitting into smaller methods. Extract out complex expressions
pyarr/readarr.py ReadarrAPI._author_json 6 ⭐ 100 🙂 13 😞 57.87% 🙂 Extract out complex expressions
pyarr/sonarr.py SonarrAPI._series_json 4 ⭐ 80 🙂 12 😞 64.24% 🙂 Extract out complex expressions
pyarr/readarr.py ReadarrAPI.add_root_folder 0 ⭐ 52 ⭐ 16 ⛔ 67.17% 🙂 Extract out complex expressions
pyarr/readarr.py ReadarrAPI.add_book 1 ⭐ 57 ⭐ 14 😞 67.76% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Archmonger
Copy link
Contributor Author

I found an interesting resource that may allow for sharing sync/async source. I will look at this later.
https://sobolevn.me/2020/06/how-async-should-have-been#combining-the-two

@acortelyou
Copy link

I found an interesting resource that may allow for sharing sync/async source. I will look at this later. https://sobolevn.me/2020/06/how-async-should-have-been#combining-the-two

Interesting article! The approach here looks like it avoids a lot of the duplicated code:
https://sobolevn.me/2020/10/higher-kinded-types-in-python#real-life-use-case

@Archmonger
Copy link
Contributor Author

Note to self: Need to rstrip("/") within the RequestHandler

@Archmonger Archmonger mentioned this pull request May 9, 2022
Closed
@Archmonger Archmonger mentioned this pull request May 24, 2022
Closed
@Archmonger
Copy link
Contributor Author

This PR is significantly out of date.

If I was to restart efforts on this, I would create a new PR anyways so I'm closing this off.

@Archmonger Archmonger closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more built-in exceptions Add tests convert to async
2 participants
@Archmonger @acortelyou