Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for angular19 #5545

Open
2 tasks done
PillowPillow opened this issue Dec 11, 2024 · 7 comments
Open
2 tasks done

Support for angular19 #5545

PillowPillow opened this issue Dec 11, 2024 · 7 comments
Labels

Comments

@PillowPillow
Copy link

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

The current version of @uppy/angular use angular 18 as a dependency and cause issue during npm update.

Solution

Update the library to use the angular 19 version.

Alternatives

use dependency override in package.jsdon

@Murderlon
Copy link
Member

We currently have no Angular expertise on the team. Do you think we can just include it in the semver range, or are things incompatible with with older versions?

@PillowPillow
Copy link
Author

I m using your v18 build with angular v19 (by overriding the package.json version), so your code seems to be compatible. However you should migrate the version using the ng cli with the "ng update" command.
It will replace for you the breaking parts.

@Murderlon
Copy link
Member

Would you be willing to contribute a PR for this?

@AravindMakam
Copy link

I have upgraded the uppy angular package to v19. I would be happy to contribute a PR.

@Murderlon
Copy link
Member

Would be great if you can make a PR for it :)

@AravindMakam
Copy link

Would be great if you can make a PR for it :)

I do not have access to check in my code..would you be providing access or whats the process for it? Can we connect?

@bdirito
Copy link
Contributor

bdirito commented Dec 23, 2024

@AravindMakam

You will want to create a personal fork of uppy

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks

Because it is your fork, you have whatever permissions you want and can push whatever changes you need.

Then, on the main (transloadit) version of uppy you will create a PR from your new version to the main version.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

That will then show up as PR from which uppy maintainers can review, approve and then merge your proposed changes from your branch to the main (transloadit) branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants