-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for angular19 #5545
Comments
We currently have no Angular expertise on the team. Do you think we can just include it in the semver range, or are things incompatible with with older versions? |
I m using your v18 build with angular v19 (by overriding the package.json version), so your code seems to be compatible. However you should migrate the version using the ng cli with the "ng update" command. |
Would you be willing to contribute a PR for this? |
I have upgraded the uppy angular package to v19. I would be happy to contribute a PR. |
Would be great if you can make a PR for it :) |
I do not have access to check in my code..would you be providing access or whats the process for it? Can we connect? |
You will want to create a personal fork of uppy Because it is your fork, you have whatever permissions you want and can push whatever changes you need. Then, on the main (transloadit) version of uppy you will create a PR from your new version to the main version. That will then show up as PR from which uppy maintainers can review, approve and then merge your proposed changes from your branch to the main (transloadit) branch. |
Initial checklist
Problem
The current version of @uppy/angular use angular 18 as a dependency and cause issue during npm update.
Solution
Update the library to use the angular 19 version.
Alternatives
use dependency override in package.jsdon
The text was updated successfully, but these errors were encountered: