Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't touch global variables from within a module #14

Open
derekr opened this issue Nov 14, 2014 · 0 comments
Open

Don't touch global variables from within a module #14

derekr opened this issue Nov 14, 2014 · 0 comments

Comments

@derekr
Copy link
Contributor

derekr commented Nov 14, 2014

https://github.com/trulia/thoth-api/blob/master/fields_mapping.js#L2

The module exports a function that should return the object instead of assigning it to a global variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants