-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.4 fixtures #57
Comments
But as the code specifically tests if the function exists before trying to use it, there's very little that can go wrong there? |
In 7.4, the function exists, but throws a deprecation information, see https://www.php.net/manual/de/migration74.deprecated.php#migration74.deprecated.core.magic-quotes-functions |
Sure, but a deprecation notice does not break the normal usage of cssmin ;-) |
Normal production software should never ignoring deprecation warnings, so this problem will throw many log hints ;) |
There are some little changes in PHP 7.4 with could break the normal usage of cssmin. Perhaps these things can be fixed:
get_magic_quotes_gpc()
isdeprecated
, see https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/blob/master/gui/index.php#L41The text was updated successfully, but these errors were encountered: