Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 fixtures #57

Open
panvid opened this issue Jan 6, 2020 · 4 comments
Open

PHP 7.4 fixtures #57

panvid opened this issue Jan 6, 2020 · 4 comments

Comments

@panvid
Copy link

panvid commented Jan 6, 2020

There are some little changes in PHP 7.4 with could break the normal usage of cssmin. Perhaps these things can be fixed:

@futtta
Copy link

futtta commented Jan 6, 2020

But as the code specifically tests if the function exists before trying to use it, there's very little that can go wrong there?
if (function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) {

@panvid
Copy link
Author

panvid commented Jan 6, 2020

In 7.4, the function exists, but throws a deprecation information, see https://www.php.net/manual/de/migration74.deprecated.php#migration74.deprecated.core.magic-quotes-functions

See: https://3v4l.org/YLTW5

@futtta
Copy link

futtta commented Jan 6, 2020

Sure, but a deprecation notice does not break the normal usage of cssmin ;-)

@panvid
Copy link
Author

panvid commented Jan 17, 2020

Normal production software should never ignoring deprecation warnings, so this problem will throw many log hints ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants