Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Monitors to mere templates #277

Open
cvonelm opened this issue Apr 20, 2023 · 0 comments
Open

Rework Monitors to mere templates #277

cvonelm opened this issue Apr 20, 2023 · 0 comments

Comments

@cvonelm
Copy link
Member

cvonelm commented Apr 20, 2023

Our zoo of monitors looks very similar: They basically just all own some set of Writers, and then if either the timer fd runs out or a Writer associated fd signals readiness to write, they call writer.write().

I have a feeling that much of the Monitor infrastructure could be reworked into such a one-liner:

GenericMonitor<ThisWriter, ThatWriter, AlsoThisWriter>

without too many asterisks attached, but then again, this might overestimate what C++ templating is capable of.

With many possible NECMonitors, NVidiaMonitors, UncoreMonitors etc. in lo2s' future this might be a worthwhile discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant