You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When implementing #49 , I tried to refactor all the code accordingly, but then functions extract_modules() and check_nested_modules() are unclear:
First, extract_modules() gets all the entries in the <modules> tag of the POM
Then, they are saved to modules_tuples together with the name of the file they are extracted from, which is always goind to be pom.xml
Then check_nested_modules() attempts to find all the "components" that appear in some modules list, however, as noted before, the component is always pom.xml which is not goind to appear in the modules list
All such identified components are saved into microservices_set, however, this set is not used to update the microservices
So it looks like it is either unfinished implementation or dead code.
The text was updated successfully, but these errors were encountered:
When implementing #49 , I tried to refactor all the code accordingly, but then functions
extract_modules()
andcheck_nested_modules()
are unclear:extract_modules()
gets all the entries in the<modules>
tag of the POMmodules_tuples
together with the name of the file they are extracted from, which is always goind to bepom.xml
check_nested_modules()
attempts to find all the "components" that appear in some modules list, however, as noted before, the component is alwayspom.xml
which is not goind to appear in the modules listmicroservices_set
, however, this set is not used to update the microservicesSo it looks like it is either unfinished implementation or dead code.
The text was updated successfully, but these errors were encountered: