Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the purspose of modules in Maven detector? #50

Open
bakhtos opened this issue Oct 22, 2024 · 0 comments
Open

What is the purspose of modules in Maven detector? #50

bakhtos opened this issue Oct 22, 2024 · 0 comments

Comments

@bakhtos
Copy link
Contributor

bakhtos commented Oct 22, 2024

When implementing #49 , I tried to refactor all the code accordingly, but then functions extract_modules() and check_nested_modules() are unclear:

  • First, extract_modules() gets all the entries in the <modules> tag of the POM
  • Then, they are saved to modules_tuples together with the name of the file they are extracted from, which is always goind to be pom.xml
  • Then check_nested_modules() attempts to find all the "components" that appear in some modules list, however, as noted before, the component is always pom.xml which is not goind to appear in the modules list
  • All such identified components are saved into microservices_set, however, this set is not used to update the microservices

So it looks like it is either unfinished implementation or dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant