We'd love your help making the project better.
In your issue, pull request, and any other communications, please remember to treat your fellow contributors with respect! We take our code of conduct seriously.
Fork, and then clone the repository:
mkdir -p $GOPATH/src/github.com/uber-go
cd $GOPATH/src/github.com/uber-go
git clone [email protected]:your_github_username/go-helix.git
cd go-helix
git remote add upstream https://github.com/uber-go/go-helix.git
git fetch upstream
Install go-helix's dependencies:
make dependencies
Make sure that the tests and the linters pass:
make test
make lint
If you're not using the minor version of Go specified in the Makefile's
LINTABLE_MINOR_VERSIONS variable, make lint doesn't do anything. This is
fine, but it means that you'll only discover lint failures after you open your
pull request.
Start by creating a new branch for your changes:
cd $GOPATH/src/github.com/uber-go/go-helix
git checkout master
git fetch upstream
git rebase upstream/master
git checkout -b cool_new_feature
Make your changes, then ensure that make lint and make test still pass. If
you're satisfied with your changes, push them to your fork.
git push origin cool_new_feature
Then use the GitHub UI to open a pull request.
At this point, you're waiting on us to review your changes. We try to respond to issues and pull requests within a few business days, and we may suggest some improvements or alternatives. Once your changes are approved, one of the project maintainers will merge them.
We're much more likely to approve your changes if you:
- Add tests for new functionality.
- Write a good commit message.
- Maintain backward compatibility.