Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in mat4.Quaternion() #37

Open
johannes-graeter opened this issue Jun 27, 2024 · 1 comment
Open

Bug in mat4.Quaternion() #37

johannes-graeter opened this issue Jun 27, 2024 · 1 comment

Comments

@johannes-graeter
Copy link

johannes-graeter commented Jun 27, 2024

Hi,
thanks a lot for filling this gap in golang!
Lets get to it: I think there is a problem in mat4.Quaternion()
A. for calculating the trace only the part of the rotation matrix should be taken (Trace3) not the tracec of the full mat4
B. IMO you need to switch on the sign of the trace to account for ambiguities, right (see f.e. eigen quaternions line 822 following....)

Best
Johannes

@ungerik
Copy link
Owner

ungerik commented Jun 27, 2024

Thanks for the feedback. Don't have the capacity to work on this right now, so I would appreciate a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants