Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude from Unicast and Multicast calls those peripheral servers which failed during Login #27

Open
chiaradiamarcelo opened this issue May 18, 2020 · 3 comments
Open

Exclude from Unicast and Multicast calls those peripheral servers which failed during Login #27

chiaradiamarcelo opened this issue May 18, 2020 · 3 comments
Labels
performance improvement

Comments

@chiaradiamarcelo
Copy link

No description provided.

@chiaradiamarcelo chiaradiamarcelo changed the title Exclude from Unicast and Multicast calls thos peripheral servers which failed during Login Exclude from Unicast and Multicast calls those peripheral servers which failed during Login May 18, 2020
@moio
Copy link
Contributor

moio commented Jun 11, 2020

What would happen with current code?

@chiaradiamarcelo
Copy link
Author

What would happen with current code?

We would perform a call anyway to those servers (even when we know they are down or failed during login), and we would return this error to the end user.

Apart from performing the extra calls, we would also be blocked waiting on this calls to timeout.

@moio
Copy link
Contributor

moio commented Jun 16, 2020

OK, so this is basically a performance improvement. Thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moio @chiaradiamarcelo