Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertx-consul-client POM not valid with java 17.0.1+ #84

Open
michalszynkiewicz opened this issue Oct 28, 2021 · 1 comment
Open

vertx-consul-client POM not valid with java 17.0.1+ #84

michalszynkiewicz opened this issue Oct 28, 2021 · 1 comment
Labels

Comments

@michalszynkiewicz
Copy link

michalszynkiewicz commented Oct 28, 2021

Version

4.1.5

Context

Building a maven project, with java 17.0.1 or newer, fails with compilation failures after:

[WARNING] The POM for io.vertx:vertx-consul-client:jar:4.1.5 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building the effective model for io.vertx:vertx-consul-client:4.1.5
[ERROR] Failed to determine activation for profile java-17 @ 

The problematic thing is:

    <profile>
      <id>java-17</id>
      <activation>
        <jdk>[17,*)</jdk>
      </activation>
      <properties>
        <maven.test.skip>true</maven.test.skip>
      </properties>
    </profile>

Commenting out the profile makes the build pass.

Do you have a reproducer?

The problem is visible in SmallRye Stork: https://github.com/smallrye/smallrye-stork/

Steps to reproduce

  1. git clone https://github.com/smallrye/smallrye-stork/
  2. mvn clean install

Extra

I see the CI build for this project fails now too with the same error

@michalszynkiewicz
Copy link
Author

CC @cescoffier

michalszynkiewicz added a commit to michalszynkiewicz/vertx-consul-client that referenced this issue Oct 28, 2021
Change the range for java-17 profile activation to `[17,)`.
According to https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html this is the way to do it and the current way `[17,*)` makes the builds fail

fixes vert-x3#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant