Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensafen short read chaining preset #4488

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Ensafen short read chaining preset #4488

merged 1 commit into from
Jan 7, 2025

Conversation

adamnovak
Copy link
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • Short read chaining preset renamed to chaining-sr and locked out for paired end inputs

Description

This renames the "sr" preset so it is more clearly using chaining and not the recommended short read mode. It also stops you from accidentally using chaining presets or the chaining flag with paired-end inputs, which can't actually run on the chaining codepath.

This renames the "sr" preset so it is more clearly using chaining and
not the recommended short read mode. It also stops you from accidentally
using chaining presets or the chaining flag with paired-end inputs,
which can't actually run on the chaining codepath.
@adamnovak
Copy link
Member Author

I'm making this against lr-giraffe, so we'd want to merge it before #4323

@adamnovak adamnovak merged commit 6eaa72b into lr-giraffe Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant