Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings -> ESS -> Grid feed-in goes to -1, 199, 299 etc Watts #1828

Closed
mpvader opened this issue Jan 11, 2025 · 2 comments · Fixed by #1846
Closed

Settings -> ESS -> Grid feed-in goes to -1, 199, 299 etc Watts #1828

mpvader opened this issue Jan 11, 2025 · 2 comments · Fixed by #1846
Assignees
@MikeTrahearn-Qinetic
Labels
bug Something isn't working
Milestone
Version 1.1.0

Comments

@mpvader
Copy link
Contributor

mpvader commented Jan 11, 2025

While it should be 0, 100, 200, …

I was able to reproduce this on Venus OS v3.60~15 within a few minutes, on this site:

https://vrm.victronenergy.com/installation/473156/firmware-update

to reproduce it, press the down button till you see -1.

IMG_3840

reported here:

I noticed the grid feed in limit goes to -1 instead of 0 then when you increase the limit again it goes in steps of 99 watts instead of 100 watts.

https://community.victronenergy.com/t/venus-os-v3-60-15-available-for-public-testing/13471
@mpvader mpvader added the bug Something isn't working label Jan 11, 2025
@mpvader mpvader added this to the Version 1.1.0 milestone Jan 11, 2025
@MikeTrahearn-Qinetic
Copy link
Contributor

MikeTrahearn-Qinetic commented Jan 13, 2025 •
edited
Loading

In this case the specific ListSpinBox (PageSettingsHub4FeedIn.qml id: maxFeedInPower) "from" property is not explicitly set to 0; rather as per the default behaviour of all ListSpinBoxes, it follows the VEQuickItem's min property, which in this case is reporting -1 from the installation.

The from value could be set to 0 to hard-code the minimum - much like the maximum is also hard-coded to 300,000.

@mpvader is this an acceptable workaround - and could there be a fix made such that the VEQuickItem in this case had its min value reported as 0 to make this a proper fix?

@MikeTrahearn-Qinetic
Copy link
Contributor

@DanielMcInnes noted that gui-v1 specifies the min value as 0 so perhaps we should do the same here then.

MikeTrahearn-Qinetic added a commit that referenced this issue Jan 15, 2025
@MikeTrahearn-Qinetic
Fix Maximum ESS Grid Feed-in could be set to -1
f1e3933 
As per Gui-v1, the maxFeedInPower ListSpinBox 'from' property
should be set to 0.

Fixes #1828
Merged
MikeTrahearn-Qinetic added a commit that referenced this issue Jan 15, 2025
@MikeTrahearn-Qinetic
Fix Maximum ESS Grid Feed-in could be set to -1
46e3cde 
As per Gui-v1, the maxFeedInPower ListSpinBox 'from' property
should be set to 0.

Fixes #1828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging a pull request may close this issue.

Fix Maximum ESS Grid Feed-in could be set to -1 victronenergy/gui-v2
3 participants
@blammit @mpvader @MikeTrahearn-Qinetic