Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lion compatibility: no Sites folder by default #8

Open
eykanal opened this issue Dec 8, 2011 · 2 comments
Open

Lion compatibility: no Sites folder by default #8

eykanal opened this issue Dec 8, 2011 · 2 comments

Comments

@eykanal
Copy link

eykanal commented Dec 8, 2011

The script assumes that the Sites folder exists, which is no longer a safe assumption in Lion; in 10.7, it only is there if the user turns on the "web sharing" option in the Sharing section of the System Preferences. I didn't check to see whether there were any other lion incompatibilities.

@sashareds
Copy link

Perhaps I am wrong.. but seems this script is not optimised for Lion/Mountain Lion at all..
It looks for virtualhosts into $APACHE_CONFIG/virtualhosts, when it should be $APACHE_CONFIG/extra/ or $APACHE_CONFIG/extra/httpd-vhosts.conf

@star-szr
Copy link
Contributor

$APACHE_CONFIG/virtualhosts is created by this script and included from httpd.conf. This allows for the structure of having one file per virtualhost and makes things like virtualhost.sh --list and virtualhost.sh --delete much more straightforward behind the scenes.

At a glance it does look like we might want to add some error handling if $DOC_ROOT_PREFIX (defaults to the Sites folder) doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants