Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: editable-layers module #38

Open
20 of 35 tasks
Tracked by #33
felixpalmer opened this issue Apr 3, 2024 · 8 comments
Open
20 of 35 tasks
Tracked by #33

Tracker: editable-layers module #38

felixpalmer opened this issue Apr 3, 2024 · 8 comments
Assignees

Comments

@felixpalmer
Copy link
Collaborator

felixpalmer commented Apr 3, 2024

v9.1+ Roadmap

  • Docs - make sure the docs get the reader up to speed on the right things.
  • MeshLayer - is it still needed? Docs says it should be replaced
  • Toolbox React component - Could it be an EditorLayer composite layer with a suite of widgets?

v9.0 - Initial forking from nebula.gl

  • Website -
  • Add editor example Add nebula examples to website #76 @birkskyum
  • Add advanced example
  • editable-layers/editable-h3-cluster-layer
  • editable-layers/sf (⚠️ renders, but throws errors)
  • editable-layers/overlays
  • editable-layers/no-map
  • editable-layers/getting-started
  • editable-layers/codesandbox
  • examples* - Make all nebula.gl examples build again
    • editable-layers/editor
    • editable-layers/advanced
    • editable-layers/editable-h3-cluster-layer
    • editable-layers/sf (⚠️ renders, but throws errors)
    • editable-layers/overlays
    • editable-layers/no-map
    • editable-layers/getting-started
    • editable-layers/codesandbox
    • Maplibre, token free basemaps, etc @birkskyum
    • React 18, functional components, etc
  • Remove @deck.gl-community/react-editable-layers chore(react-editable-layers): Remove module, move code into editor example. #96
    • Create new react module @deck.gl-community/react
    • Move independent react components from @deck.gl-community/react-editable-layers to @deck.gl-community/react @ibgreen
    • Move overlays to @deck.gl-community/react
    • Move EditorModal to @deck.gl-community/react
    • Toolbox component - move toeditor example.
  • forking

Background

nebula.gl has become stale, and it is not possible to migrate it to deck.gl v9 easily. A number of project depend on it, in particular the EditableGeojsonLayer. In order to move forward, the code will be moved into this repo and published under a new npm package

@donmccurdy
Copy link
Collaborator

I'm working on updating the repo to v9 now. I'll start with the bing-maps module and example, migrating them to TypeScript at the same time.

@ibgreen ibgreen pinned this issue Apr 4, 2024
@donmccurdy
Copy link
Collaborator

donmccurdy commented Apr 9, 2024

Progress on editable-layers:

I've added a checkbox for each of the editable-layers examples to the OP above, some are now working, others still need to be ported.

@donmccurdy donmccurdy mentioned this issue Apr 10, 2024
12 tasks
@ibgreen ibgreen changed the title Editable-layers tracker Tracker: editable-layers module Apr 15, 2024
@ibgreen ibgreen mentioned this issue May 2, 2024
@mariush2
Copy link

mariush2 commented Jul 5, 2024

Hi, was unsure if I should create an issue for feature-requests or comment here. I saw in the history of the nebula.gl repo that the "MeasureDistance" mode for the "EditableGeoJson" layer was changed to only support multiple lengths being measured at once, instead of the user clicking two points only. Is this something that can be added, or is it something I could contribute with into this package?

@ibgreen
Copy link
Contributor

ibgreen commented Jul 5, 2024

@mariush2 We are still looking for volunteers to help maintain editable-layers, in the mean-time contributions are welcome.

Please consider whether you can make the change without breaking existing apps or perhaps you need a new measurement mode.

@nipeone
Copy link

nipeone commented Jul 16, 2024

@ibgreen Hi, I migrated the issue from roadmap to here and deleted the original issue. Is there any plan to support brush mode? For example to create a large area with brush, or for example if you are not satisfied with a closed area created with polygon and you need to continue adding or removing it with brush!

@ibgreen
Copy link
Contributor

ibgreen commented Jul 16, 2024

@nipeone Unfortunately, the editable-layers module doesn't have a named maintainer, so there is no one who can answer that.

As you can see, the current roadmap is focused on just keeping the functionality alive and completing the fork from the stale nebula.gl repo.

There is a willingness to accept PRs if they are clean and simple and of course we'd warmly welcome anyone who wanted to help with maintenance.

@dm2x46
Copy link

dm2x46 commented Jul 22, 2024

Hi @ibgreen, do you have any plans to update the GeoJSON type for editable layers, similar to the GeoJSON type in deck.gl v9?

@ibgreen
Copy link
Contributor

ibgreen commented Jul 22, 2024

@dm2x46 Please ask questions in the GitHub discussions page. This is a tracker task for the module, not a discussion space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants