Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Removing the default RTLTextPlugin #7

Open
KiwiKilian opened this issue Oct 25, 2024 · 0 comments · May be fixed by #8
Open

[Feat] Removing the default RTLTextPlugin #7

KiwiKilian opened this issue Oct 25, 2024 · 0 comments · May be fixed by #8

Comments

@KiwiKilian
Copy link

KiwiKilian commented Oct 25, 2024

Target Use Case

As previously discussed, I would like to remove the default RTL plugin loaded from mapbox.com.

From a data privacy point it would be much superior to remove the default and let the developer specify a source, if RTL support is needed. No alternative default should be specified.

Proposal

I'm happy to draft a PR with the default value for RTLTextPlugin removed. Is a breaking change fine within this initial release or would this only be going in for 2.0?

I would also like to change the shape of the prop, providing full control:

RTLTextPlugin={{
  pluginUrl: "...",
  lazy: true,
}}
@KiwiKilian KiwiKilian changed the title [Feat] Removing the default RTL Plugin [Feat] Removing the default RTLTextPlugin Oct 25, 2024
@KiwiKilian KiwiKilian linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant