Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo for Angular #1

Open
yjorayev opened this issue Jun 24, 2019 · 4 comments
Open

Demo for Angular #1

yjorayev opened this issue Jun 24, 2019 · 4 comments

Comments

@yjorayev
Copy link

Could you add sample using Angular please? Thanks!

@dhilt
Copy link

dhilt commented Dec 18, 2019

https://github.com/dhilt/ngx-ui-scroll -- this lib (Angular) supports dynamic heights and has a lot of demo samples

@vitalif I'm sorry to be so forward, but perhaps it might be a good idea to provide a link to ngx-ui-scroll in your project' Readme, where you list the libs that have no dynamic heights feature...

@vitalif
Copy link
Owner

vitalif commented Dec 18, 2019

Ok, I'll check it. On my mobile phone it doesn't work smooth though, I can't reach the end of the viewport with a single move.

I don't like Angular ("DI" is enough for me to dislike it) so I don't care too much about examples. If someone makes an example I'll add a link to the repo of course. It's just a library that I share, not a product that I want to promote after all.

@vitalif
Copy link
Owner

vitalif commented Dec 18, 2019

https://github.com/dhilt/ngx-ui-scroll -- this lib (Angular) supports dynamic heights and has a lot of demo samples

https://yourcmc.ru/wiki/images/6/6a/Ngx-ui-scroll.mp4

That's what I'm talking about - first scrolling is really weird. So yeah, I'll add it to README as another example of a library that doesn't perform well with dynamic item heights :)

@dhilt
Copy link

dhilt commented Dec 18, 2019

@vitalif oh I see... the thing is the scroller in this demo does not know the viewport' height on start, it doesn't try to emulate invisible rows, that's why the expansion of the viewport occurs run-time and requires more and more scrolls. There are min/max index settings that allow to have such an emulation out-of-box, but we understand that the average height will be recalculated per each internal workflow cycle, so the result cannot be precise and you'll probably need to make 2-3 (not just one) scrolls to reach the bottom line. So that particular demo is about uncertain heights AND uncertain dataset limits.

Anyway thanks for mentioning! In the end it is a great idea to have pure js virtualizing core, covering all cases, well tested and providing clear enough API to integrate it with random framework... So your work is something that might have a great future I guess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants