Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTO VJ not working when scratch control (timecode vinyl) enabled #11

Open
donmurdoc opened this issue Sep 28, 2024 · 16 comments
Open

AUTO VJ not working when scratch control (timecode vinyl) enabled #11

donmurdoc opened this issue Sep 28, 2024 · 16 comments
Labels
bug Something isn't working [core] Related to the core/message bus module enhancement New feature or request

Comments

@donmurdoc
Copy link

Hi, auto vj works fine in my setup, but when I enable vinyl control, video stops displaying (blank).
If I go back to internal mode, I get the video back.

@vladkorotnev
Copy link
Owner

vladkorotnev commented Sep 28, 2024 via email

@donmurdoc
Copy link
Author

donmurdoc commented Sep 30, 2024

Hi, ok so this is the log. I'm playing a track with scratch control, nothing really happens, and then I de-activate timecode, and autovj starts working

scratch log.txt

@vladkorotnev
Copy link
Owner

vladkorotnev commented Oct 2, 2024

I tried to do it myself but it doesn't seem to have any effect, still getting the video and the ticks in the logs. I presume this is the right setting?
image

How do you activate scratch control?

cc @ErikMinekus this might be up your alley since my code isn't doing much about Traktor integration

@donmurdoc
Copy link
Author

You need to have setup an audio interface, and run through it a traktor timecode signal, so as to actually activate the timecode control. Once traktor recognizes a timecode signal, you can actually activate it:

Screenshot 2024-10-02 at 09 48 27

@vladkorotnev
Copy link
Owner

If you disconnect the input signal and keep things silent, does the thing work fine, up until it manages to detect the signal then?

@donmurdoc
Copy link
Author

aa.mp4

I'll upload a video (even tho I'm using traktor 4, this also happens with traktor 3)

Here, I when I'm playing a trak without timecode control, it plays ok. But when I activate timecode control, it stops (and no update on console)

BUT when I move the vinyl, console updates (there's ticks?) even tho no video playback

@vladkorotnev
Copy link
Owner

Oh, now I think I understand

When you turn on the vinyl control, it turns off the play button, thus it's not considered "on air" by the software and the video disappears.

If you could please drop the log with it playing but vinyl mode on (the play button is not green, but the vinyl control is enabled so the track is going on), I might find a way to track that condition, if there is enough information being sent from Traktor.

On a sidenote I wonder if other similar apps support vinyl now. And thanks for the heads up that it works with Traktor 4, I really want to try it out and this is one less thing to worry about. The auto stems thing sounds crazy!

@vladkorotnev vladkorotnev added bug Something isn't working enhancement New feature or request [core] Related to the core/message bus module labels Oct 2, 2024
@donmurdoc
Copy link
Author

To be sure, do I just copy and paste the messages from the console for the log, or there's a better way to get it?

@vladkorotnev
Copy link
Owner

Running the command as ./traktor-obs-relay | tee debug.log would record it into a file (I presume you are on a Mac)

Also please change the log level from Trace to Debug so that the size is a bit more bearable

@donmurdoc
Copy link
Author

https://github.com/user-attachments/assets/f379c060-a48d-4f1c-939f-0e579171e1b5
OK here's a video, and the log of that video.
As you can see, I start the script, with timecode running, I load a track, no video, I scratch a bit, then I disable timecode (press play) and video starts.

debug.log

@vladkorotnev
Copy link
Owner

vladkorotnev commented Oct 3, 2024

Thanks, I'll try to take a look during the coming weeks. Things are a bit piled up here so I don't have an exact timeframe.

@donmurdoc
Copy link
Author

Also, idk if you knew about this:

https://devpost.com/software/video-happy

But that functionality I think is still in traktor, just hidden

Repository owner deleted a comment from donmurdoc Oct 3, 2024
@vladkorotnev
Copy link
Owner

Interesting, I didn't know that existed. I wonder if it's outputting it via midi or something.

As a temporary workaround, what happens if you go into api.js and change the line 59 from

let newTracks = Object.fromEntries( info.songsOnAir.filter(x => x.isPlaying == true).map(x => [x.filePath, x]) );

to

let newTracks = Object.fromEntries( info.songsOnAir.map(x => [x.filePath, x]) );

In theory that removes the requirement for the play button, but as a consequence stopped songs will turn up a video player too as soon as they aren't closed behind the faders. Let me know if that works for you!

@donmurdoc
Copy link
Author

Nope, it's still the same, no video with timecode on

@vladkorotnev
Copy link
Owner

Oh, there is one more thing to change in the Traktor side counterpart:

https://github.com/ErikMinekus/traktor-api-client/blob/main/D2/Api/ApiDeck.qml#L118-L129

In this block, change the value for isRunning to be just true instead of propIsPlaying.value.

Otherwise there won't be ticks coming from the deck unless the play button is hit.

FWIW, keep backups of all the files we're changing here, as I don't know if we might explode something as a side effect :P

@donmurdoc
Copy link
Author

Ok, still no video, but that actually changed. Now in the console, I see updates, but the video is not displaying.
I attach log

debug2.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [core] Related to the core/message bus module enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants