Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel status for channels not existing on Akeneo #122

Open
lruozzi9 opened this issue Mar 7, 2022 · 1 comment
Open

Channel status for channels not existing on Akeneo #122

lruozzi9 opened this issue Mar 7, 2022 · 1 comment
Assignees
@LucaGallinari
Labels
bug Something isn't working question Further information is requested RFC Request for Comments

Comments

@lruozzi9
Copy link
Member

lruozzi9 commented Mar 7, 2022

At the moment the Product importer will disable the product for all the channels and then enable it for again all the channels:

SyliusAkeneoPlugin/src/Product/Importer.php

Line 233 in 8873f8e

private function handleChannels(ProductInterface $product, array $productVariantResponse): void
Is this logic right? Should not we handle only the channels that are existing on Akeneo?
@lruozzi9 lruozzi9 added question Further information is requested RFC Request for Comments labels Mar 7, 2022
@LucaGallinari
Copy link
Member

Yes, you are right

@LucaGallinari LucaGallinari self-assigned this Mar 14, 2022
@LucaGallinari LucaGallinari added the bug Something isn't working label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucaGallinari LucaGallinari

Labels
bug Something isn't working question Further information is requested RFC Request for Comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucaGallinari @lruozzi9