Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling more than one variant axes #76

Open
aleho opened this issue Apr 29, 2021 · 2 comments
Open

Handling more than one variant axes #76

aleho opened this issue Apr 29, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@aleho
Copy link
Contributor

aleho commented Apr 29, 2021

Currently the "direct" parent of a product is created / retrieved when importing products with more than one variant.

Sylius doesn't support the two levels of Akeneo, but it does support multiple options, generating a variant of the combinations.

On import the options are resolved in ProductOptionsResolver by only considering the first tier.
Likewise, in Product\Importer and ProductAssociations\Importer only the "direct" parent of a variant is considered (1st axis variant if 2nd axis) instead of the root product.

We've changed the importers / option resolver to check the parent of a parent and also to import all options locally. This works well because the 2nd tier variantCode matches the Akeneo code anyway.

What's your take on this?
Are you planning on supporting the second Akeneo variant axis level?

@mmenozzi
Copy link
Member

mmenozzi commented May 6, 2021

Hi @aleho, honestly we never needed the 2nd axis level and this is the reason why the plugin currently supports the first level only.

If you already worked on that and you can provide a PR we'll be happy to merge it!

@mmenozzi mmenozzi added the enhancement New feature or request label May 6, 2021
@mmenozzi mmenozzi changed the title Handling more than one variant Handling more than one variant axes Jun 3, 2021
@aleho
Copy link
Contributor Author

aleho commented Mar 15, 2023

Sorry, we stopped using Sylius because their rate of development, acceptance of already approved PRs and appalling handling of confirmed serious bugs (e.g. in invoicing) were just too much to handle in the long run.

We had so many forks and bug fixes to track locally (with many @see SyliusBugTracker that it became a matter of weeks to update to newer versions.

Feel free to close this issue if you don't think it's relevant to you and thank you very much for the great cooperation! Really appreciate it!

@aleho aleho removed their assignment Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants