Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search highlighting does not work on Windows #101

Open
ZNielsen opened this issue Aug 2, 2021 · 0 comments
Open

Search highlighting does not work on Windows #101

ZNielsen opened this issue Aug 2, 2021 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ZNielsen
Copy link
Collaborator

ZNielsen commented Aug 2, 2021 •
edited
Loading

See discussion in #100

let tmp = split(execute('his /'), '\n')

We need to add some platform detection, Windows needs to split on \r\n
@ZNielsen ZNielsen added the bug Something isn't working label Aug 2, 2021
@ZNielsen ZNielsen changed the title Search highlighting does not work on windows Search highlighting does not work on Windows Aug 2, 2021
ZNielsen added a commit to ZNielsen/minimap.vim that referenced this issue Oct 6, 2021
@ZNielsen
wfxrGH-101 - Fix windows line endings
6d526ac 
A couple places assumed unix line endings, but the Search function/unit
tests heavily relied on it. This commit detects the platform and changes
the used line endings accordingly.
@ZNielsen ZNielsen mentioned this issue Oct 6, 2021
Closed
19 tasks
ZNielsen added a commit to ZNielsen/minimap.vim that referenced this issue Dec 14, 2021
@ZNielsen
wfxrGH-101 - Fix windows line endings
399463d 
A couple places assumed unix line endings, but the Search function/unit
tests heavily relied on it. This commit detects the platform and changes
the used line endings accordingly.
@ZNielsen ZNielsen added the help wanted Extra attention is needed label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix windows line endings ZNielsen/minimap.vim
1 participant
@ZNielsen