Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize_song is deprecated #20

Closed
dotX12 opened this issue Apr 27, 2024 · 1 comment · Fixed by #21
Closed

recognize_song is deprecated #20

dotX12 opened this issue Apr 27, 2024 · 1 comment · Fixed by #21
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dotX12
Copy link

dotX12 commented Apr 27, 2024

Hi, I use this cli from time to time, can you fix the work with the audio segment and not use deprecated recognize_song?

return await shazam.recognize_song(input) # type: ignore

An example of how to transfer bytes from an AudioSegment is described here:
shazamio/ShazamIO#103 (comment)

@woodruffw
Copy link
Owner

Thanks for the report! I don't have any immediate time to work on this, but I'll get to it eventually. In the mean time, I'd be happy to review a patch that uses the non-deprecated API in case anybody feels like tackling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants