Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog metrics V3 #396

Open
Tracked by #1315
nplasterer opened this issue Jun 25, 2024 · 1 comment
Open
Tracked by #1315

Datadog metrics V3 #396

nplasterer opened this issue Jun 25, 2024 · 1 comment

Comments

@nplasterer
Copy link
Contributor

nplasterer commented Jun 25, 2024

Add more detailed metric logging for V3 with dashboards.

@richardhuaaa
Copy link
Contributor

HOW TO GET STARTED

So this is where the MLS endpoints are defined:

func (s *Service) FetchKeyPackages(ctx context.Context, req *mlsv1.FetchKeyPackagesRequest) (*mlsv1.FetchKeyPackagesResponse, error) {

and identity endpoints:
func (s *Service) PublishIdentityUpdate(ctx context.Context, req *api.PublishIdentityUpdateRequest) (*api.PublishIdentityUpdateResponse, error) {

You can add any logging you might be interested in, might also be worth comparing this with any logging we might have in the old (non-MLS) endpoints:

log := s.log.Named("publish").With(zap.String("content_topic", env.ContentTopic))

You can also look through metrics for the old service in our dashboards, and try to recreate them for MLS: https://app.datadoghq.com/dashboard/lists

@mchenani mchenani removed their assignment Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants