New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve password storage for security #58

Open

maximemenager opened this issue Oct 28, 2022 · 0 comments

Collaborator

maximemenager commented Oct 28, 2022 •

edited

Loading

Hi !

Currently there is only a sha256 sum used to store the password in the database (for example).
This is considered as a bad practice. See here

We should either:

(at least) Add a salt to the shasum in order to avoid rainbow tables uses if the database leaks.
(best) Use a proven secured function (like Argon2), which adds layers of security (like preventing timing attacks).

For more informations:
https://security.stackexchange.com/questions/195563/why-is-sha-256-not-good-for-passwords
https://dusted.codes/sha-256-is-not-a-secure-password-hashing-algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment