Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid ShareToken name and symbol #173

Open
Majorfi opened this issue Jun 22, 2022 · 1 comment · May be fixed by #181
Open

Invalid ShareToken name and symbol #173

Majorfi opened this issue Jun 22, 2022 · 1 comment · May be fixed by #181
Assignees
Labels
bug Something isn't working

Comments

@Majorfi
Copy link

Majorfi commented Jun 22, 2022

With the following request, the result is invalid, with shareToken.symbol === "\"\"" and shareToken.name === "\"\""

Link here for the vault on Fantom Network.
Name and Symbol are correct on contract.

{
  vault(id: "0x0a0b23d9786963de69cb2447dc125c49929419d8") {
    id
    token{
      id
      decimals
      symbol
      name
    }
    shareToken {
      id
      decimals
      symbol
      name
    }
  }
}

Result

{
  "data": {
    "vault": {
      "id": "0x0a0b23d9786963de69cb2447dc125c49929419d8",
      "token": {
        "id": "0x82f0b8b456c1a451378467398982d4834b6829c1",
        "decimals": 18,
        "symbol": "MIM",
        "name": "Magic Internet Money"
      },
      "shareToken": {
        "id": "0x0a0b23d9786963de69cb2447dc125c49929419d8",
        "decimals": 18,
        "symbol": "\"\"",
        "name": "\"\""
      }
    }
  }
}
@Majorfi Majorfi added the bug Something isn't working label Jun 22, 2022
@0xkofee
Copy link

0xkofee commented Jul 2, 2022

i'll take a look

looks like the vault has no name because when it was created it wasn't given a name until later. https://ftmscan.com/tx/0xf610aadea5b7304f569e4727d5ade90577ba92ae3129af431f14c83a00137458

@0xkofee 0xkofee linked a pull request Jul 26, 2022 that will close this issue
@rareweasel rareweasel linked a pull request Jul 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants