#829 Turn AndInThreadsTest Stable #874

pbenety · 2018-05-16T00:45:16Z

Turn AndInThreadsTest stable for #829

0crat · 2018-05-16T00:45:35Z

Job #874 is now in scope, role is REV

codecov-io · 2018-05-16T00:55:31Z

Codecov Report

Merging #874 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #874   +/-   ##
=========================================
  Coverage     86.07%   86.07%           
  Complexity     1445     1445           
=========================================
  Files           259      259           
  Lines          3770     3770           
  Branches        212      212           
=========================================
  Hits           3245     3245           
  Misses          475      475           
  Partials         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf47f1...688d6d5. Read the comment docs.

0crat · 2018-05-16T12:56:23Z

This pull request #874 is assigned to @paulodamaso /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

paulodamaso

@pbenety Thanks for the PR, I've made some remarks, please take a look at them.

paulodamaso · 2018-05-17T14:31:48Z

src/test/java/org/cactoos/scalar/AndInThreadsTest.java

+        );
+        MatcherAssert.assertThat(
+            list,
+            Matchers.containsInAnyOrder("hello", "world")


@pbenety We shouldn't use these static functions from Matchers, please fix it.

@paulodamaso What should I use instead?

@pbenety Using IsIterableContainingInAnyOrder<> from hamcrest will do the trick.

paulodamaso · 2018-05-17T14:32:02Z

src/test/java/org/cactoos/scalar/AndInThreadsTest.java

-            list.size(),
-            Matchers.equalTo(2)
+            list,
+            Matchers.contains(1, 1)


@pbenety We shouldn't use these static functions from Matchers, please fix it.

@paulodamaso What should I use instead?

@pbenety Using IsIterableContainingInAnyOrder<> from hamcrest will do the trick.

paulodamaso · 2018-05-17T14:37:28Z

src/test/java/org/cactoos/scalar/AndInThreadsTest.java

-        final List<String> list = new LinkedList<>();
+        final List<String> list = Collections.synchronizedList(
+            new ArrayList<String>(2)
+        );


@pbenety What do you think about using cactoos SyncCollection here?

@paulodamaso I thought about it but SyncCollection does not implement add method.

@pbenety Right, it needs to be mutable for the test, so that's ok for now. Just open a @todo about removing these static methods access from here so we can think about it in the future.

@paulodamaso @todo added.

paulodamaso · 2018-05-17T14:37:46Z

src/test/java/org/cactoos/scalar/AndInThreadsTest.java

-        final List<String> list = new LinkedList<>();
+        final List<String> list = Collections.synchronizedList(
+            new ArrayList<String>(2)
+        );


@pbenety What do you think about using cactoos SyncCollection here too?

@paulodamaso I thought about it but SyncCollection does not implement add method.

@pbenety Same as above.

@paulodamaso @todo added.

paulodamaso · 2018-05-17T14:37:58Z

src/test/java/org/cactoos/scalar/AndInThreadsTest.java

-        final List<Integer> list = new LinkedList<>();
+        final List<Integer> list = Collections.synchronizedList(
+            new ArrayList<Integer>(2)
+        );


@pbenety What do you think about using cactoos SyncCollection here, again?

@paulodamaso I thought about it but SyncCollection does not implement add method.

@pbenety Same as above.

@paulodamaso @todo added.

paulodamaso · 2018-05-22T02:07:40Z

@pbenety Please see Travis build details and correct build failure cause.

pbenety · 2018-05-22T02:50:45Z

@paulodamaso done

paulodamaso · 2018-05-22T02:54:38Z

@pbenety Everything looks good now, thank you for the fixes and the patience!

paulodamaso

@pbenety All good now. thanks.

paulodamaso · 2018-05-22T02:55:50Z

@rultor good to merge

rultor · 2018-05-22T02:57:16Z

@rultor good to merge

@paulodamaso Thanks for your request. @llorllale Please confirm this.

llorllale · 2018-05-22T14:31:15Z

@rultor merge

rultor · 2018-05-22T14:33:28Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2018-05-22T14:42:42Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 9min)

0crat · 2018-05-22T14:59:17Z

@elenavolokhova /z please review this job completed by @paulodamaso /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat · 2018-05-22T15:00:47Z

The job #874 is now out of scope

0crat · 2018-05-22T15:01:08Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

elenavolokhova · 2018-05-22T18:05:59Z

@0crat quality good

0crat · 2018-05-22T18:08:59Z

Order was finished, quality is "good": +20 point(s) just awarded to @paulodamaso /z

0crat · 2018-05-22T18:09:02Z

Quality review completed: +8 point(s) just awarded to @elenavolokhova /z

0crat added the scope label May 16, 2018

pbenety mentioned this pull request May 16, 2018

Tests for AndInThreads are not stable #829

Closed

paulodamaso suggested changes May 17, 2018

View reviewed changes

pbenety force-pushed the 829_make_AndInThreads_test_stable branch from 5a48ed9 to 3a1327f Compare May 22, 2018 01:39

pbenety force-pushed the 829_make_AndInThreads_test_stable branch from 3a1327f to 30501cc Compare May 22, 2018 02:14

pbenety added 2 commits May 21, 2018 23:15

(yegor256#829) Turn AndInThreadsTest Stable

0284285

(yegor256#829) Fix PR issues

688d6d5

pbenety force-pushed the 829_make_AndInThreads_test_stable branch from 30501cc to 688d6d5 Compare May 22, 2018 02:41

paulodamaso approved these changes May 22, 2018

View reviewed changes

rultor merged commit 688d6d5 into yegor256:master May 22, 2018

0crat removed the scope label May 22, 2018

#829 Turn AndInThreadsTest Stable #874

#829 Turn AndInThreadsTest Stable #874

Conversation

pbenety commented May 16, 2018

0crat commented May 16, 2018

codecov-io commented May 16, 2018 • edited Loading

Codecov Report

0crat commented May 16, 2018

paulodamaso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulodamaso May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pbenety May 22, 2018 • edited Loading

Choose a reason for hiding this comment

paulodamaso May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pbenety May 22, 2018 • edited Loading

Choose a reason for hiding this comment

paulodamaso May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pbenety May 22, 2018 • edited Loading

Choose a reason for hiding this comment

paulodamaso commented May 22, 2018 • edited Loading

pbenety commented May 22, 2018

paulodamaso commented May 22, 2018

paulodamaso left a comment

Choose a reason for hiding this comment

paulodamaso commented May 22, 2018

rultor commented May 22, 2018

llorllale commented May 22, 2018

rultor commented May 22, 2018

rultor commented May 22, 2018

0crat commented May 22, 2018

0crat commented May 22, 2018

0crat commented May 22, 2018

elenavolokhova commented May 22, 2018

0crat commented May 22, 2018

0crat commented May 22, 2018

codecov-io commented May 16, 2018 •

edited

Loading

paulodamaso May 17, 2018 •

edited

Loading

pbenety May 22, 2018 •

edited

Loading

paulodamaso May 17, 2018 •

edited

Loading

pbenety May 22, 2018 •

edited

Loading

paulodamaso May 17, 2018 •

edited

Loading

pbenety May 22, 2018 •

edited

Loading

paulodamaso commented May 22, 2018 •

edited

Loading