Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default query configurable #334

Closed
juliustens-db opened this issue Mar 31, 2024 · 3 comments
Closed

make default query configurable #334

juliustens-db opened this issue Mar 31, 2024 · 3 comments

Comments

@juliustens-db
Copy link

Hey there! First of all, thanks for the great project! This is just the missing puzzle piece in the linked data ecosystem I was desperately longing for a few years ago ❤️

Now to my "issue": I think it would be useful to be able to configure a custom default query shown to people who open the YASGUI editor for the first time (e.g. to customize the default prefixes, showcase a simple query on your data, or both).

Given my understanding of YASGUI, there is a parameter for that, which would only need to be exposed and passed via the plugin config. I'd gladly create a PR for this change, but wanted to get some feedback first if anyone objects to that 😄.

@ktk
Copy link
Member

ktk commented Apr 1, 2024

Hi Julius,

Thanks for the kind words!

Indeed not a bad idea, the ?s ?p ?o is a bit very generic and not very useful for newcomers indeed.

I think it's not a bad idea to make the default query easier configurable so users can adjust it to whatever they think makes more sense. I would just propose that it does not change the default config in case it's not touched.

Also I think it's related to #59, the question is always what should a good starting page be and maybe we should think about that in this issue as well.

@ludovicm67
Copy link
Member

Done! It's now possible to configure the default query using the defaultQuery configuration field of the Trifid plugin.

Here is an example: https://github.com/zazuko/trifid/blob/7ef2e4443ac71c86c935e2f9c5716206b074c54f/packages/yasgui/README.md

Released in trifid-plugin-yasgui v3.1.0 which is part of trifid v5.0.3.

@juliustens-db
Copy link
Author

Thanks!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants