Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The filter of samples.yaml of DFU sample seems not to work as expected #84196

Open
nandojve opened this issue Jan 19, 2025 · 0 comments
Open
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@nandojve
Copy link
Member

Describe the bug
The dfu sample filter seems not to work. It should select only boards when slot0_partition and slot1_partition are define.

filter:
    dt_label_with_parent_compat_enabled("slot0_partition", "fixed-partitions")
and dt_label_with_parent_compat_enabled("slot1_partition", "fixed-partitions") and dt_chosen_enabled("zephyr,flash-controller")
and CONFIG_FLASH_HAS_DRIVER_ENABLED

This means that boards that define a partition, like storage, should never been selected because the final devicetree is defined without those partitions. See below fragment from same54_xpro:

nvmctrl: nvmctrl@41004000 {
	compatible = "atmel,sam0-nvmctrl";
	reg = < 0x41004000 0x22 >;
	interrupts = < 0x1d 0x0 >, < 0x1e 0x0 >;
	#address-cells = < 0x1 >;
	#size-cells = < 0x1 >;
	lock-regions = < 0x20 >;
	flash0: flash@0 {
		compatible = "soc-nv-flash";
		write-block-size = < 0x8 >;
		reg = < 0x0 0x100000 >;
		partitions {
			compatible = "fixed-partitions";
			#address-cells = < 0x1 >;
			#size-cells = < 0x1 >;
			storage_partition: partition@fc000 {
				label = "storage";
				reg = < 0xfc000 0x4000 >;
			};
		};
	};
};

The issue was found on https://github.com/zephyrproject-rtos/zephyr/actions/runs/12832618368/job/35789498048?pr=84118

To Reproduce
Steps to reproduce the behavior:

west twister -p same54_xpro/same54p20a -s sample.usb.dfu.permanent.download --no-detailed-test-id

Expected behavior
Twister filter can filter the conditions. This could avoid add unrelated boards to exclusion list and keep CI sane. Otherwise changes on these platforms can never be catch.

Impact
CI false positives and integration delays

Logs and console output
Details can be found at https://github.com/zephyrproject-rtos/zephyr/actions/runs/12832618368/job/35789498048?pr=84118

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK 0.17
  • Commit SHA: mainline
@nandojve nandojve added the bug The issue is a bug, or the PR is fixing a bug label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

1 participant