Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Playback Percentage is included as a trigger (which uses the UA Video events tag.) #6

Open
KZeni opened this issue Oct 17, 2019 · 0 comments

Comments

@KZeni
Copy link
Contributor

KZeni commented Oct 17, 2019

I looked to propose this as a pull request, but the triggerId of my export didn't match up anymore.

                "name": "Media Playback Percentage",
                "type": "CUSTOM_EVENT",
                "customEventFilter": [
                    {
                        "type": "EQUALS",
                        "parameter": [
                            {
                                "type": "TEMPLATE",
                                "key": "arg0",
                                "value": "{{_event}}"
                            },
                            {
                                "type": "TEMPLATE",
                                "key": "arg1",
                                "value": "gtm4wp.mediaPlaybackPercentage"
                            }
                        ]
                    }
                ],

is effectively the trigger details (gtm4wp.mediaPlaybackPercentage being the important element here per GTM4WP.) I then attached this to the pre-existing UA Video events tag since its setup is just as fitting for the percentage as it is for the state change.

I'm thinking it would be a worthwhile addition to this since GTM4WP already has this while this container doesn't have it implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant